Fix build errors and a crash in xcode 15 #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rcancro
reviewed
Sep 8, 2023
Source/Details/ASGraphicsContext.mm
Outdated
| @@ -121,7 +121,9 @@ NS_INLINE void ASConfigureExtendedRange(UIGraphicsImageRendererFormat *format) | |||
| } | |||
|
|
|||
| // Bad OS or experiment flag. Use UIGraphics* API. | |||
| UIGraphicsBeginImageContextWithOptions(size, opaque, scale); | |||
| if (size.width > 0 && size.height > 0) { | |||
| UIGraphicsBeginImageContextWithOptions(size, opaque, scale); | |||
There was a problem hiding this comment.
If we have an invalid size, I think we should exit early and return nil. Shortly after starting the image context we call UIGraphicsGetImageFromCurrentImageContext and UIGraphicsEndImageContext. I'm not sure what the behavior is if we end a graphics context without starting one.
There was a problem hiding this comment.
I've switched to an early return
rcancro
approved these changes
Sep 8, 2023
andrey-golovin-ios
added a commit
to andrey-golovin-ios/Texture
that referenced
this pull request
Oct 5, 2023
* 'master' of https://github.com/TextureGroup/Texture: Fix build errors and a crash in xcode 15 (TextureGroup#2093) [ASCellNodeVisibilityEvent] Add a new event when scrolling stops (TextureGroup#2084) Trying to get CI to work (TextureGroup#2085) fix typo: ASStackLayoutElement.h (TextureGroup#2067) Docs: Fix references of ASViewController/ASNavigationController (non-existent) to ASDKViewController/ASDKNavigationController (TextureGroup#2072) [ASTextKitRenderer] Adding locking when accessing the text renderer cache (TextureGroup#2075) Switch UITextWritingDirection to NSWritingDirection (TextureGroup#2071)
|
Is this code is also available in the released version that is 3.1.0, because we're unable to find it in 3.1.0 release. |
|
Is this issue happening only if the app is built using XCode 15? |
nickaroot
added a commit
to nickaroot/Texture
that referenced
this pull request
Jan 29, 2024
Fix build errors and a crash in xcode 15 (TextureGroup#2093)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build errors when trying to compile with xcode15.
It also fixes a crash happening on XCode15 when attempting to create a new image with either a height or width of 0 or less (UIGraphicsBeginImageContextWithOptions). This can happen when isCancelled returns true.